New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle case where no translations were found #30951
Merged
fabpot
merged 1 commit into
symfony:3.4
from
greg0ire:fix-warning-in-translation-check-tool
Apr 7, 2019
Merged
Handle case where no translations were found #30951
fabpot
merged 1 commit into
symfony:3.4
from
greg0ire:fix-warning-in-translation-check-tool
Apr 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the program emits a warning when trying to use max() on an empty array.
greg0ire
force-pushed
the
fix-warning-in-translation-check-tool
branch
from
April 7, 2019 08:01
4b75362
to
79b1fb8
Compare
Before
After
|
javiereguiluz
approved these changes
Apr 7, 2019
stof
reviewed
Apr 7, 2019
fabpot
approved these changes
Apr 7, 2019
Thank you @greg0ire. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Handle case where no translations were found | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Right now, the program emits a warning when trying to use max() on an empty array. Commits ------- 79b1fb8 Handle case where no translations were found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the program emits a warning when trying to use max() on an
empty array.